[FFmpeg-cvslog] r12233 - in trunk/libavcodec: Makefile avcodec.h dct-test.c dsputil.c faanidct.c faanidct.h utils.c

[Aurelien Jacobs]

Michael Niedermayer wrote:

> On Tue, Feb 26, 2008 at 11:52:58PM +0100, Diego Biurrun wrote:
> > On Tue, Feb 26, 2008 at 06:58:00PM +0100, Diego Biurrun wrote:
> > > On Tue, Feb 26, 2008 at 03:59:12PM +0100, michael wrote:
> > > > 
> > > > Log:
> > > > floating point AAN IDCT
> > > > 
> > > > Added:
> > > >    trunk/libavcodec/faanidct.c
> > > >    trunk/libavcodec/faanidct.h
> > > > 
> > > > --- (empty file)
> > > > +++ trunk/libavcodec/faanidct.h	Tue Feb 26 15:59:11 2008
> > > > @@ -0,0 +1,3 @@
> > > > +void ff_faanidct(DCTELEM block[64]);
> > > > +void ff_faanidct_add(uint8_t *dest, int line_size, DCTELEM
> > > > block[64]); +void ff_faanidct_put(uint8_t *dest, int line_size,
> > > > DCTELEM block[64]);
> > > 
> > > Can we please have license headers on all new files?  Thank you.
> > 
> > Also, this is missing multiple inclusion guards.
> 
> It does not need multiple inclusion guards, it can safely be included
> multiple times :)

But this would safely introduce some "redundant redeclaration"
warnings ;-)

Moreover, I guess check_headers will chock on this one. It is missing:
  #include <stdint.h>
  #include "dsputil.h"

Aurel