[FFmpeg-cvslog] r12241 - trunk/libavformat/mov.c

[Baptiste Coudurier]

Hi Diego,

Diego Biurrun wrote:
> On Tue, Feb 26, 2008 at 07:50:14PM +0100, Baptiste Coudurier wrote:
>> Reimar D?ffinger wrote:
>>>> @@ -1451,6 +1529,13 @@ static int mov_read_header(AVFormatConte
>>>>          sc->ffindex = i;
>>>>          mov_build_index(mov, st);
>>>>  
>>>> +        if (sc->dref_id-1 < sc->drefs_count && sc->drefs[sc->dref_id-1].path) {
>>>> +            if (url_fopen(&sc->pb, sc->drefs[sc->dref_id-1].path, URL_RDONLY) < 0)
>>>> +                av_log(s, AV_LOG_ERROR, "stream %d, error opening external essence: %s\n",
>>>> +                       st->index, strerror(errno));
>>>> +        } else
>>>> +            sc->pb = s->pb;
>>> This must be a joke. Or do you seriously consider it acceptable for a
>>> demuxer to do url_fopen?!
>> Please do not whine. Give valid reasons AND suggest another correct way
>> to handle those files.
> 
> So you are going to implement all missing features in MOV?  Even the
> ones in the MPlayer MOV demuxer? :)

I suggest Reimar to help with that instead of whining.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312