[FFmpeg-cvslog] r12241 - trunk/libavformat/mov.c

Baptiste Coudurier baptiste.coudurier
Wed Feb 27 14:34:32 CET 2008


Reimar D?ffinger wrote:
> On Wed, Feb 27, 2008 at 01:35:29PM +0100, Baptiste Coudurier wrote:
>> Reimar D?ffinger wrote:
>>> On Wed, Feb 27, 2008 at 12:52:54PM +0100, Reimar D?ffinger wrote:
>>>> On Wed, Feb 27, 2008 at 12:33:08PM +0100, Baptiste Coudurier wrote:
>>>>> Now Im curious, considering mov layout and libavformat mechanisms, what
>>>>> would you expect to leak or read, besides what the user application is
>>>>> allowed to read anyway (url_fopen suceeds), and what would be different
>>>>> than garbage from a genuine self-contained file.
>>>> Do you really not get the point?
>>> Or alternatively, am I the only one who sees any of these points as really
>>> _critical_? I am sorry if I annoy you because I am completely at odds
>>> with your opinions, but to me this kind of behaviour feels just as bad
>>> as any buffer overflow, and I can't help that it is considered a feature
>>> just drives me crazy.
>> The problem is that you don't see any use of this feature, and fail to
>> understand why it is useful, but you should first read specs of 'alis'
>> and Alias Record functionnality.
> 
> Usefulness as an excuse for a horrible implementation? Reminds me of
> ActiveX...

Implementation has nothing horrible here, it is the simplest.
Path parsing is nothing clean though, see similar code everywhere.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312





More information about the ffmpeg-cvslog mailing list