[FFmpeg-cvslog] r12241 - trunk/libavformat/mov.c

[Michael Niedermayer]

On Wed, Feb 27, 2008 at 02:10:54PM +0100, Baptiste Coudurier wrote:
> Hi Michael,
> 
> Michael Niedermayer wrote:
> > On Wed, Feb 27, 2008 at 01:04:17PM +0100, Reimar D?ffinger wrote:
> >> On Wed, Feb 27, 2008 at 12:52:54PM +0100, Reimar D?ffinger wrote:
> >>> On Wed, Feb 27, 2008 at 12:33:08PM +0100, Baptiste Coudurier wrote:
> >>>> Now Im curious, considering mov layout and libavformat mechanisms, what
> >>>> would you expect to leak or read, besides what the user application is
> >>>> allowed to read anyway (url_fopen suceeds), and what would be different
> >>>> than garbage from a genuine self-contained file.
> >>> Do you really not get the point?
> >> Or alternatively, am I the only one who sees any of these points as really
> >> _critical_? I am sorry if I annoy you because I am completely at odds
> >> with your opinions, but to me this kind of behaviour feels just as bad
> >> as any buffer overflow, and I can't help that it is considered a feature
> >> just drives me crazy.
> > 
> > I agree that the thing should be disabled by default.
> > About the callback, honestly i dont mind either way, its simpler without
> > a callback ...
> > 
> 
> Ok, Patch attached.

I also thought (like everyone else) that this would allow remote urls to be
opened. As this seems not to be the case, iam not insisting on this to be
disabled by default, at least not unless we find an actual security issue
in it.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080227/da07540f/attachment.pgp>