[FFmpeg-cvslog] r11326 - in trunk: configure libavutil/internal.h

[Diego Biurrun]

On Fri, Dec 28, 2007 at 09:31:49PM +0200, Ivan Kalvachev wrote:
> On Dec 28, 2007 5:54 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Fri, Dec 28, 2007 at 04:46:26PM +0200, Ivan Kalvachev wrote:
> > > On Dec 27, 2007 3:53 AM, diego <subversion at mplayerhq.hu> wrote:
> > > >
> > > > Log:
> > > > Check for the presence of llrint(), lrint(), round() and roundf()
> > > > and provide simple replacements if they are unavailable.
> > > > patch by Michael Kostylev, mik niipt ru
> > > >
> > > > Modified:
> > > >    trunk/configure
> > > >    trunk/libavutil/internal.h
> > >
> > > Would you be so kind when you commit changes in FFmpeg that break
> > > MPlayer to fix MPlayer too, instead of leaving it broken for (more
> > > than 2) days?
> >
> > Would you be so kind as to either fix issues yourself or alternatively
> > refrain from complaining?
> 
> I had just found out. While I was writing fix
> somebody else proposed better one.

I don't care when you find out about things.  I repeat:

Would you be so kind as to either fix issues yourself or alternatively
refrain from complaining?

> > It's holiday season and I don't compile MPlayer multiple times a day.
> 
> It doesn't require super sharp coding skill to figure out that if
> ffmpeg configure is changed then probably mplayer configure may need
> to be changed too.

Good.  This means there is no need for a build system guru to take care
of things.  In other words, you can do it yourself and you don't need to
prod or flame me into doing it.

> > > You are still MPlayer developer, aren't you?
> >
> > Send your sarcasm straight to /dev/null.  As somebody who does little
> > more than flame I would stay silent more often.  Count the number of
> > patches I managed to commit while all you managed to do was flame.
> 
> You managed to commit 3 patches in MPlayer after the change here.
> I can hardly believe you don't have time to compile MPlayer before commit.
> Most probably you worked with outdated repository.

I don't distclean before every commit.  It's simply not necessary.

> All I want is this situation never to happen again.
> Would you be more careful in future?

I don't feel an obligation to fix any problems introduced by FFmpeg
changes myself, irrespective of whether I did the actual commit or not.
I'm also not inclined to do you any kind of favor, you do not return
them anyway.

If you want to avoid this situation *work* for it.  No amount of
flaming will help.

Diego