[FFmpeg-cvslog] r11326 - in trunk: configure libavutil/internal.h

[Baptiste Coudurier]

Hi

Reimar D?ffinger wrote:
> Hello,
> On Fri, Dec 28, 2007 at 04:54:53PM +0100, Diego Biurrun wrote:
>> On Fri, Dec 28, 2007 at 04:46:26PM +0200, Ivan Kalvachev wrote:
>>> On Dec 27, 2007 3:53 AM, diego <subversion at mplayerhq.hu> wrote:
>>>> Log:
>>>> Check for the presence of llrint(), lrint(), round() and roundf()
>>>> and provide simple replacements if they are unavailable.
>>>> patch by Michael Kostylev, mik niipt ru
>>>>
>>>> Modified:
>>>>    trunk/configure
>>>>    trunk/libavutil/internal.h
>>> Would you be so kind when you commit changes in FFmpeg that break
>>> MPlayer to fix MPlayer too, instead of leaving it broken for (more
>>> than 2) days?
>> Would you be so kind as to either fix issues yourself or alternatively
>> refrain from complaining?
> 
> The point is that it is much easier for you than anyone else since you
> know what exactly changed and know configure quite well.
> I don't expect you to check every change to FFmpeg if it breaks MPlayer,
> nor do I think that you are "required" to fix it, but your response
> still seems over-the-top to me.
> 

If only Mplayer could stick with using FFmpeg API you would avoid many
of the recurring problems.

IMHO there shouldn't be any reason modifying FFmpeg libavutil/internal.h
or configure would break Mplayer.

Btw, demux_mkv.c is including <ffmpeg/intreadwrite.h> which is not an
installed header.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312