[FFmpeg-cvslog] r11638 - in trunk: libavcodec/avcodec.h libavformat/isom.c libavformat/mov.c

[Reimar Döffinger]

Hello,
On Sun, Jan 27, 2008 at 09:13:19PM +0100, Michael Niedermayer wrote:
> On Sun, Jan 27, 2008 at 08:57:04PM +0100, reimar wrote:
> > Author: reimar
> > Date: Sun Jan 27 20:57:04 2008
> > New Revision: 11638
> > 
> > Log:
> > Add CODEC_ID_MOV_TEXT and use it instead of modifying the stream in the mov demuxer.
> [...]
> > Modified: trunk/libavformat/mov.c
> > ==============================================================================
> > --- trunk/libavformat/mov.c	(original)
> > +++ trunk/libavformat/mov.c	Sun Jan 27 20:57:04 2008
> > @@ -1543,12 +1543,6 @@ static int mov_read_packet(AVFormatConte
> >      } else {
> >  #endif
> >          av_get_packet(s->pb, pkt, sample->size);
> > -        if (s->streams[sc->ffindex]->codec->codec_id == CODEC_ID_TEXT) {
> > -            int textlen = FFMIN(AV_RB16(pkt->data), sample->size - 2);
> > -            textlen = FFMAX(textlen, 0);
> > -            memmove(pkt->data, pkt->data + 2, textlen);
> > -            pkt->size = textlen;
> > -        }
> 
> 
> btw, a bitstream filter doing above would be welcome

Hm.. is a bitstream filter though the best way to do this? I do not
really like that there is basically only the name for these filters, no
way to give incoming/outgoing codec id etc, which means every
application must code explicit support for this kind of thing...

Greetings,
Reimar D?ffinger