[FFmpeg-cvslog] r11691 - trunk/libavformat/movenc.c

[Baptiste Coudurier]

Reimar D?ffinger wrote:
> Hello,
> On Thu, Jan 31, 2008 at 12:46:42PM +0100, Baptiste Coudurier wrote:
>> Reimar D?ffinger wrote:
>>> On Thu, Jan 31, 2008 at 12:31:56PM +0100, bcoudurier wrote:
>>>> @@ -483,6 +483,14 @@ static const AVCodecTag codec_3gp_tags[]
>>>>      { CODEC_ID_AMR_WB, MKTAG('s','a','w','b') },
>>>>  };
>>>>  
>>>> +static const AVCodecTag mov_pix_fmt_tags[] = {
>>>> +    { PIX_FMT_YUYV422, MKTAG('y','u','v','s') },
>>>> +    { PIX_FMT_YUYV422, MKTAG('2','v','u','y') },
>>> I think this is wrong, the yuv2 samples I have seen use signed values
>>> (i.e. memset 0 gives a black screen)
>>> for the U,V planes whereas YUYV422 uses the usual unsigned (memset 0
>>> giving the typical green).
>>> Samples should be on our samples server, if you can't find them tell me
>>> and I'll look for them.
>>>
>> No, this is correct:
>> http://developer.apple.com/quicktime/icefloe/dispatch020.html
>>
>> You are speaking about 'yuv2'.
> 
> Argh, right. I forgot that Apple likes this "write things reverse" game and
> assumed that they would be the same.

Hehe, btw I would be interested in supporting such samples, should we
add a new pix fmt for it ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312