[FFmpeg-cvslog] r14168 - trunk/libavformat/psxstr.c

[Michael Niedermayer]

On Fri, Jul 11, 2008 at 06:37:00PM +0100, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
> 
> > On Fri, Jul 11, 2008 at 04:41:44PM +0100, M?ns Rullg?rd wrote:
> >> 
> >> michael wrote:
> >> > Author: michael
> >> > Date: Fri Jul 11 17:12:44 2008
> >> > New Revision: 14168
> >> >
> >> > Log:
> >> > simplify
> >> 
> >> Just as I was thinking the previous commit message was bad...
> >
> > I do not really mind that one, it is not (supposed to be) a functional
> > change, so what "important" information is missing here? The affected
> > file might not have hurt, but is seems a minor thing to me.
> 
> Yes, there is not supposed to be any functional change.  However, bugs
> happen, and if I'm trying to figure out why something broke, it's nice
> to be able to easily tell which commits might be relevant.  If the
> commit message mentions psxstr, I know I can safely ignore it when
> debugging some other format, for instance.  Seeing only "simplify", I
> have to look at the diff to determine the irrelevance of this change.
> 

> I'm tempted to add a hook enforcing at least three words in a commit
> message.  It is simply not possible to be accurate enough in only one
> or two words.

reindent, fixing typo and simplify are clear unless they are misused but
i dont remember them being misused ...

I dont need a asshat hook that requires me to write "simplified some code"
that does not help anyone.

The part which is changed should be mentioned only when its not obvious
from the file changed.

for git, git-log --stat will show you which files changed with the messages.



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080711/efde71cb/attachment.pgp>