[FFmpeg-cvslog] r14218 - trunk/libavcodec/ra288.c

[Reimar Döffinger]

Hello,
On Sun, Jul 13, 2008 at 10:41:09PM +0200, vitor wrote:
> Author: vitor
> Date: Sun Jul 13 22:41:09 2008
> New Revision: 14218
> 
> Log:
> Simplify
> 
> Modified:
>    trunk/libavcodec/ra288.c
> 
> Modified: trunk/libavcodec/ra288.c
> ==============================================================================
> --- trunk/libavcodec/ra288.c	(original)
> +++ trunk/libavcodec/ra288.c	Sun Jul 13 22:41:09 2008
> @@ -69,9 +69,7 @@ static void decode(Real288_internal *glo
>      for (x=0; x < 5; x++)
>          buffer[x] = codetable[cb_coef][x] * sumsum;
>  
> -    sum = scalar_product_float(buffer, buffer, 5) / 5;
> -
> -    sum = FFMAX(sum, 1);
> +    sum = FFMAX(1, scalar_product_float(buffer, buffer, 5) / 5);

Personally I think this is more an obfuscation than a simplification,
there is just too much in one line. It's not bad enough that I would
object, but stop simplifying before the whole file is in one line ;-)