[FFmpeg-cvslog] r14209 - in trunk/libavformat: allformats.c gifdec.c

[Diego Biurrun]

On Mon, Jul 14, 2008 at 05:54:59PM +0200, Michael Niedermayer wrote:
> On Mon, Jul 14, 2008 at 10:20:52AM +0100, M?ns Rullg?rd wrote:
> > 
> > Diego Biurrun wrote:
> > > On Sun, Jul 13, 2008 at 08:47:24PM +0200, michael wrote:
> > >>
> > >> Log:
> > >> Remove gif demuxer, the code contains a gif decoder and lzw decoder neither
> > >> belongs in a demuxer, furthermore the code might be exploitable.
> > >> Fixes issue530
> > >>
> > >> Removed:
> > >>    trunk/libavformat/gifdec.c
> > >> Modified:
> > >>    trunk/libavformat/allformats.c
> > >
> > > Did you even compile this change?  You forgot to remove the entry from
> > > the Makefile.  100l I guess...
> 
> Of course did i test it, including the whole regression tests.

:)

> > He may have run configure before compiling.  That would disable it,
> > even though the entry was still in the makefile.
> 
> exactly

Your fine is reduced to 50l then, 10l if you make it Pepsi ;)

Diego