[FFmpeg-cvslog] r14267 - trunk/libavcodec/ra288.c

[Michael Niedermayer]

On Fri, Jul 18, 2008 at 09:40:22AM +0200, Benoit Fouet wrote:
> M?ns Rullg?rd wrote:
> > Vitor Sessak <vitor1001 at gmail.com> writes:
> >   
> >> M?ns Rullg?rd wrote:
> >>     
> >>> Vitor Sessak <vitor1001 at gmail.com> writes:
> >>>
> >>>       
> >>>> Diego Biurrun wrote:
> >>>>         
> >>>>> On Fri, Jul 18, 2008 at 12:42:23AM +0200, vitor wrote:
> >>>>>           
> >>>>>> Log:
> >>>>>> Simplify
> >>>>>>             
> >>>>> Can we *please* have more descriptive commit messages?  How long can it
> >>>>> take you to explain *what* you simplified?
> >>>>>           
> >>>> For such obvious cleanups I'm against spending more time thinking about 
> >>>> the commit message than doing the code changes (even more so as what is 
> >>>> "cleaner" is a matter of taste, so it is non trivial to explain why the 
> >>>> new code is better in a commit msg). But if you could suggest anything 
> >>>> better that I could copy-paste for those kind of clean-up commits, I'd 
> >>>> happily do so.
> >>>>         
> >>> A simple "ra288:" prefix would suffice in this case.
> >>>       
> >> Then we go back to the flamewar about if the commit messages should be 
> >> understandable with or without seeing the list of changed files. From 
> >> what I followed of the discussion, this is a problem almost only for 
> >> git.
> >>     
> >
> > Here's some sample output from "svn log":
> >
> > ------------------------------------------------------------------------
> > r14274 | mru | 2008-07-18 02:07:17 +0100 (Fri, 18 Jul 2008) | 4 lines
> >
> > MPEGTS: Improve probe function
> >
> > When a sync byte is found, check that transport_error_indicator is zero,
> > and adaptation_field_control is valid (non-zero).
> > ------------------------------------------------------------------------
> > r14273 | bcoudurier | 2008-07-18 01:24:31 +0100 (Fri, 18 Jul 2008) | 1 line
> >
> > cosmetics, remove space
> > ------------------------------------------------------------------------
> > r14272 | bcoudurier | 2008-07-18 01:23:37 +0100 (Fri, 18 Jul 2008) | 1 line
> >
> > return max score when ftyp atom is encoutered
> > ------------------------------------------------------------------------
> > r14268 | vitor | 2008-07-17 23:59:53 +0100 (Thu, 17 Jul 2008) | 1 line
> >
> > Simplify
> > ------------------------------------------------------------------------
> > r14263 | diego | 2008-07-17 17:28:48 +0100 (Thu, 17 Jul 2008) | 3 lines
> >
> > Replace LDLATEFLAGS hackery by proper LDFLAGS tests.
> > The original reasons for LDLATEFLAGS are lost in the mists of time.
> >
> > ------------------------------------------------------------------------
> >
> > Looking at this, how would you know what was simplified in r14268?
> > Contrast this with the information given for r14274.
> >
> >   
> 
> come on, you just have to add a -v to your command line, and you'll get
> the changed path
> I really don't see the point of all this...

neither do I ...

also, a simple quickly written one line script: (improvments welcome)

tr '\n' '?' <log | sed 's/lines\??Changed paths://g;s#/trunk/libav##g;s#/trunk/##g;s/?   \([AMD]\) /  \1 /g;s/r\([0-9]*\) | \([0-9a-zA-Z]*\) |/  \1 \2\t /g;s/00 ([A-Z][a-z][a-z], [0-9][0-9] [A-Z][a-z][a-z] 200[0-9]) |\([^\?]*\)?/\1/g;s/?--*?/??/g' | tr '?' '\n' >log2


transforms the messy svn log -v output into:


  14218 vitor     2008-07-13 22:41:09 +02 1   M codec/ra288.c
Simplify

  14217 vitor     2008-07-13 22:39:55 +02 1   M codec/ra288.c
Another av_clipf() usage

  14216 vitor     2008-07-13 22:38:42 +02 1   M codec/ra288.c
Do not declare as double a var that only stores a float

  14215 vitor     2008-07-13 22:36:32 +02 1   M codec/ra288.c
Simplify: use FFMAX

  14214 reimar    2008-07-13 22:03:57 +02 2   M codec/lzw.c
check that csize in ff_lzw_decode_init is < LZW_MAXBITS, <= is not enough and
might read outside the prefix array

  14213 vitor     2008-07-13 21:59:44 +02 1   M codec/ra288.c  M util/common.h
Add av_clipf() function to common.h and use it in ra288.c

  14212 mru       2008-07-13 21:41:13 +02 1   M codec/dvdsubdec.c
dvdsubdec: allow compilation with -DDEBUG

  14211 mru       2008-07-13 21:41:10 +02 1   M format/rtpdec.c  M format/rtpenc.c
RTP: use dprintf(), allow compilation with -DDEBUG

  14210 mru       2008-07-13 21:41:07 +02 1   M format/asf.c
ASF: use dprintf(), allow compilation with -DDEBUG


One can clearly see that the extra prefixes arent usefull in this output
and of course they are even less usefull if one looks at the log of a
single file.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080718/afdfa9bc/attachment.pgp>