[FFmpeg-cvslog] r14484 - in trunk/libavcodec: audioconvert.c audioconvert.h

[Aurelien Jacobs]

On Fri, 1 Aug 2008 00:11:15 +1000
pross at xvid.org wrote:

> On Thu, Jul 31, 2008 at 03:35:05PM +0200, Benoit Fouet wrote:
> > pross wrote:
> > > Modified: trunk/libavcodec/audioconvert.c
> > > ==============================================================================
> > > --- trunk/libavcodec/audioconvert.c	(original)
> > > +++ trunk/libavcodec/audioconvert.c	Thu Jul 31 14:55:06 2008
> > > @@ -25,7 +25,49 @@
> > >   * @author Michael Niedermayer <michaelni at gmx.at>
> > >   */
> > >  
> > > -#include "avcodec.h"
> > >   
> > 
> > why did you remove this one ?
> > isn't it needed by the file ?
> 
> avcodec.h is provided by audioconvert.h.
> 
> Indeed, this change was unnecessary and could have been comitted later,
> seperately.  I'll avoid such changes in future...

Not only unnecessary, but even bad.
The usage here is that every file must include every headers that it
requires directly. You should not rely on one header including another
(except when it's explicitely documented so, such as inttypes.h
including stdint.h).
So here you should add back the avcodec.h include.

Aurel