[FFmpeg-cvslog] r13854 - trunk/libavcodec/opt.h

Stefano Sabatini stefano.sabatini-lala
Sun Jun 22 14:44:42 CEST 2008


On date Sunday 2008-06-22 13:50:31 +0200, Diego Biurrun wrote:
> On Sat, Jun 21, 2008 at 11:15:49AM +0200, stefano wrote:
> > 
> > Log:
> > Extend documentation for AVOption.
> > 
> > --- trunk/libavcodec/opt.h	(original)
> > +++ trunk/libavcodec/opt.h	Sat Jun 21 11:15:49 2008
> > @@ -52,12 +52,20 @@ typedef struct AVOption {
> > +
> > +    /**
> > +     * The offset relative to the context structure where the option
> > +     * value is stored. It should be 0 for named constant.
> 
> constantS
> 
> Please review your patches/commits for plural 's' and third person
> singular 's' mistakes, you skip them regularly.

Yes, and sorry for that.

> > +    /**
> > +     * the default value for non-constant and value for constant scalars
> > +     */
> >      double default_val;
> 
> I don't understand.  s/value for// ?

That string has been suggested by MN, yes it's a little terse but I
think the meaning is this:

the default value for non-constant scalar options, here "default" is
specified because the value itself may change, and value for constant
scalar options, in this case "default" isn't necessary since the
option has a constant value.

I'll commit the typo fixes if you don't have any other comments on
this.

Regards.




More information about the ffmpeg-cvslog mailing list