[FFmpeg-cvslog] r13854 - trunk/libavcodec/opt.h

[Stefano Sabatini]

On date Tuesday 2008-06-24 11:18:32 +0200, Diego Biurrun wrote:
> On Sun, Jun 22, 2008 at 02:44:42PM +0200, Stefano Sabatini wrote:
> > On date Sunday 2008-06-22 13:50:31 +0200, Diego Biurrun wrote:
> > > On Sat, Jun 21, 2008 at 11:15:49AM +0200, stefano wrote:
> > > > 
> > > > Log:
> > > > Extend documentation for AVOption.
> > > > 
> > > > --- trunk/libavcodec/opt.h	(original)
> > > > +++ trunk/libavcodec/opt.h	Sat Jun 21 11:15:49 2008
> > > > @@ -52,12 +52,20 @@ typedef struct AVOption {
> > > > +
> > > > +    /**
> > > > +     * the default value for non-constant and value for constant scalars
> > > > +     */
> > > >      double default_val;
> > > 
> > > I don't understand.  s/value for// ?
> > 
> > That string has been suggested by MN, yes it's a little terse but I
> > think the meaning is this:
> > 
> > the default value for non-constant scalar options, here "default" is
> > specified because the value itself may change, and value for constant
> > scalar options, in this case "default" isn't necessary since the
> > option has a constant value.
> 
> I think the current description is misleading.  At the very least, it
> confused me.  I would suggest just
> 
>   default value for scalar options
> 
> It is kind of implied that constant options are immutable while others
> are not...

OK with me, I'll apply after three days if no one has other comments.

Regards.