[FFmpeg-cvslog] r13971 - trunk/libavcodec/vorbis_dec.c

[Baptiste Coudurier]

Michael Niedermayer wrote:
> On Wed, Jun 25, 2008 at 11:38:55AM -0700, Baptiste Coudurier wrote:
>> Hi Michael,
>> 
>> michael wrote:
>>> Author: michael Date: Wed Jun 25 20:35:24 2008 New Revision:
>>> 13971
>>> 
>>> Log: Set frame_size to the gcd of what the decoder can output.
>>> 
>> I fear this will have sideeffects (streamcopy).
> 
> dont fear, the only ffmpeg revission with working vorbis streamcopy
> is on my hd. :) And it depends on this change!

Hehe ok.

>> Wouldn't be better to unset it when frame size is variable ?
> 
> libvorbis.c sets it too ... and i need it in nutenc.c

I think mov can support it correctly too, assuming packets have correct
timestamps, I think stsd frame size must be to 0 according to specs
though since it is variable, but stts must be set correctly to packet
duration.

> Having a vorbis parser which could fetch frame size ?
> 
> a parser setting AVPacket.duration is very welcome! frame size is not
> the correct variable to set

Yes, since packets can have different durations.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA