[FFmpeg-cvslog] r12444 - trunk/configure

[Diego Biurrun]

On Sat, Mar 15, 2008 at 12:27:28PM +0000, M?ns Rullg?rd wrote:
> diego <subversion at mplayerhq.hu> writes:
> 
> > Log:
> > cosmetics: Reformat Apple cc check.
> >
> > --- trunk/configure	(original)
> > +++ trunk/configure	Sat Mar 15 10:45:06 2008
> > @@ -1532,9 +1532,11 @@ fi
> >
> >  # AltiVec flags: The FSF version of GCC differs from the Apple version
> >  if enabled altivec; then
> > -    test -n "`$cc -v 2>&1 | grep version | grep Apple`" &&
> > -        add_cflags "-faltivec" ||
> > +    if test -n "`$cc -v 2>&1 | grep version | grep Apple`"; then
> 
> Tests like this should use grep -q.

There are a few more similar tests.

> > +        add_cflags "-faltivec"
> > +    else
> >          add_cflags "-maltivec -mabi=altivec"
> > +    fi
> 
> Wouldn't it be better to check which flags are actually supported by
> the compiler?  Theoretically, Apple could some day release a fixed
> version.

In fact, they already did.  The test is done properly now.

Diego