[FFmpeg-cvslog] r13128 - in trunk/libavcodec: Makefile armv4l/dsputil_arm.c armv4l/float_arm_vfp.c

[Guillaume POIRIER]

Hello,

On Mon, May 12, 2008 at 12:46 AM, M?ns Rullg?rd <mans at mansr.com> wrote:
> gpoirier <subversion at mplayerhq.hu> writes:
>
>  > Author: gpoirier
>  > Date: Sun May 11 22:06:03 2008
>  > New Revision: 13128
>  >
>  > Log:
>  > Add some initial optimizations for ARM VFP (floating
>  > point coprocessor available in some ARM11 cores).
>  > Patch by Siarhei Siamashka % siarhei.siamashka at gmail.com %
>  > Original thread:
>  > date: Apr 20, 2008 5:41 PM
>  > subject: [FFmpeg-devel] [PATCH] Some ARM VFP optimizations (vector_fmul, vector_fmul_reverse, float_to_int16)
>  >
>  > Added:
>  >    trunk/libavcodec/armv4l/float_arm_vfp.c
>  > Modified:
>  >    trunk/libavcodec/Makefile
>  >    trunk/libavcodec/armv4l/dsputil_arm.c
>  >
>  > Modified: trunk/libavcodec/Makefile
>  > ==============================================================================
>  > --- trunk/libavcodec/Makefile (original)
>  > +++ trunk/libavcodec/Makefile Sun May 11 22:06:03 2008
>  > @@ -419,6 +419,8 @@ ASM_OBJS-$(HAVE_ARMV5TE)               +
>  >
>  >  ASM_OBJS-$(HAVE_ARMV6)                 += armv4l/simple_idct_armv6.o \
>  >
>  > +ASM_OBJS-$(HAVE_ARMVFP)                += armv4l/float_arm_vfp.o \
>
>  This is wrong.  It should be added to OBJS-$(HAVE_ARMVFP) since the
>  file is a C file (not a .S file).

How should it be fixed? Like in arm_vfp_fix.1.diff or arm_vfp_fix.2.diff?

Guillaume
-- 
I don't measure a man's success by how high he climbs but how high he
bounces when he hits bottom.
 -- George S. Patton
-------------- next part --------------
A non-text attachment was scrubbed...
Name: arm_vfp_fix.1.diff
Type: application/octet-stream
Size: 547 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080512/708b8352/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: arm_vfp_fix.2.diff
Type: application/octet-stream
Size: 703 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080512/708b8352/attachment-0001.obj>