[FFmpeg-cvslog] r13241 - in trunk/libavformat: matroska.h matroskadec.c

Michael Niedermayer michaelni
Fri May 23 01:16:23 CEST 2008


On Fri, May 23, 2008 at 12:07:09AM +0200, aurel wrote:
> Author: aurel
> Date: Fri May 23 00:07:09 2008
> New Revision: 13241
> 
> Log:
> demux chapters out of matroska
> patch by Anton Khirnov  wyskas _at_ gmail _dot_ com

[...]

> +                    if(start != AV_NOPTS_VALUE && end != AV_NOPTS_VALUE)
> +                        res = ff_new_chapter(s, start * AV_TIME_BASE / 1000000000 , end * AV_TIME_BASE / 1000000000, title ? title : "(unnamed)");

"(unnamed)" is unacceptable, title in AVChapter should be NULL if its unknown!

The way it is muxers would have to check for "(unnamed)" to be able to mux it
properly.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080523/a376428f/attachment.pgp>



More information about the ffmpeg-cvslog mailing list