[FFmpeg-cvslog] r13277 - trunk/libavcodec/ra144.c

[Vitor Sessak]

Michael Niedermayer wrote:
> On Sat, May 24, 2008 at 11:20:09AM +0200, vitor wrote:
>> Author: vitor
>> Date: Sat May 24 11:20:09 2008
>> New Revision: 13277
>>
>> Log:
>> Simplify final()
> [...]
>> -        x = ptr[10] - sum;
> [...]
>>  
>> -        if (x<-32768 || x>32767) {
>> +        if (ptr[10] - sum < -32768 || ptr[10] - sum > 32767) {
> [...]
>> -        ptr[10] = x;
>> +        ptr[10] -= sum;
> 
> I would not call that part simplification.

Why? I found that adding a auxiliary var just to simplify an if 
obfuscate the code (it's harder to see that with no overflow, this code 
just do ptr[10] -= sum)...

-Vitor