[FFmpeg-cvslog] r27778 - in trunk/libswscale: rgb2rgb_template.c swscale-example.c swscale.c swscale_template.c yuv2rgb_template.c yuv2rgb_vis.c

[David Conrad]

On Oct 17, 2008, at 12:27 AM, Luca Barbato wrote:

> On 17-10-2008 5:10, David Conrad wrote:
>> On Oct 16, 2008, at 10:18 PM, Mike Melanson wrote:
>>
>>> flameeyes wrote:
>>>> Author: flameeyes
>>>> Date: Thu Oct 16 15:34:30 2008
>>>> New Revision: 27778
>>>>
>>>> Log:
>>>> Convert asm keyword into __asm__.
>>>>
>>>> Neither the asm() nor the __asm__() keyword is not part of the C99
>>>> standard, but while GCC accepts the former in C89 syntax, it is not
>>>> accepted in C99 unless GNU extensions are turned on (with -fasm).  
>>>> The
>>>> latter form is accepted in any syntax as an extension (without
>>>> requiring further command-line options).
>>>>
>>>> Sun Studio C99 compiler also does not accept asm() while accepting
>>>> __asm__(), albeit reporting warnings that it's not valid C99 synta.
>>>
>>> I'm pretty sure this broke PPC/Linux builds.
>>
>> It looks like it was ffmpeg r15629 instead; at least that's what's
>> breaking PPC/Mac OS X.
>> Attached patch should fix it (typeof() vs. __typeof__() in the same  
>> vein
>> as asm() vs. __asm__())
>>
>
> Issue reproduced and patch tested on gcc-4.3 on linux, works as well.

Slightly updated patch to not break alignment of \ in macros.

Any objections to the patch? typeof is a gcc extension and isn't  
accepted without gnu extensions enabled which ffmpeg no longer does.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: swscale-typeof.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20081019/e1590dbc/attachment.txt>
-------------- next part --------------