[FFmpeg-cvslog] r15151 - in trunk: configure libavcodec/Makefile

[Diego Biurrun]

On Tue, Sep 02, 2008 at 08:17:41PM -0400, Justin Ruggles wrote:
> M?ns Rullg?rd wrote:
> > Justin Ruggles <justin.ruggles at gmail.com> writes:
> > 
> >> I don't completely agree with Aurel that they should be treated
> >> equally.  E-AC-3 is a superset of AC-3.  The user may want to disable
> >> that superset to save size, but keep the base AC-3 support.  It is
> >> fairly easy thing to do if we choose to allow it.
> > 
> > Having the option to disable E-AC-3 only might be useful.
> 
> I can see a problem now with disabling the E-AC-3 decoder but not AC-3.
>  The codec_id is tied to the AVCodec, so any E-AC-3 content would be
> rejected if eac3_decoder is disabled.  That is not good, because an AC-3
> decoder can also handle E-AC-3 content, it just doesn't decode it.  It
> is required to look at the bitstream id in each frame's header and skip
> it if it doesn't handle it.  This allows for the decoding of mixed
> streams, which are assigned the E-AC-3 codec_id.
> 
> I'm open to suggestions for a clean way to allow both codec_id's while
> not compiling full E-AC-3 support.

I think it's perfectly acceptable to fail on things marked E-AC-3 if
E-AC-3 decoding support is not enabled...

Diego