[FFmpeg-cvslog] r15215 - trunk/libavformat/riff.c

[Michael Niedermayer]

On Sat, Sep 06, 2008 at 03:17:52PM -0700, Baptiste Coudurier wrote:
> Michael Niedermayer wrote:
> > On Thu, Sep 04, 2008 at 08:42:09PM -0700, Mike Melanson wrote:
> >> bcoudurier wrote:
> >>> Author: bcoudurier
> >>> Date: Fri Sep  5 04:20:33 2008
> >>> New Revision: 15215
> >>>
> >>> Log:
> >>> simplify bps code by using av_get_bits_per_sample
> >>>
> >>> Modified:
> >>>    trunk/libavformat/riff.c
> >> This change broke this regression for all configurations:
> > 
> > I will revert this change in 24h as it seems baptiste isnt around to
> > look into this.
> > 
> > Also the change looks wrong, as it changes the bps for wma from 16 to 0
> > 
> 
> Humm, yes, sorry, it seems old code was setting default value to 16,
> however I still have problems with wma reg tests here, and when I run
> it, I thought this was ok :(
> 
> Even if I revert or apply attached patch, I still have the attached diff.

attached patch to riff.c looks ok
and about the remaining regression errors, well IMHO the offending patches
where just minor cleanp & factorization and should just be reverted.
Other solutions where suggested but suggestions alone dont solve it.


> 
> Btw according to specs,
> http://msdn.microsoft.com/en-us/library/ms713497.aspx:
> "wBitsPerSample
> 
> Bits per sample for the wFormatTag format type. If wFormatTag is
> WAVE_FORMAT_PCM, then wBitsPerSample should be equal to 8 or 16. For
> non-PCM formats, this member must be set according to the manufacturer's
> specification of the format tag. If wFormatTag is
> WAVE_FORMAT_EXTENSIBLE, this value can be any integer multiple of 8 and
> represents the container size, not necessarily the sample size; for
> example, a 20-bit sample size is in a 24-bit container. Some compression
> schemes cannot define a value for wBitsPerSample, so this member can be 0."
> 
> I agree that if it was working with 16 before, better let it as 16.

Ive checked 3 wmas and according to mplayer they have all 16 bits per sample.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080907/7d95c7b7/attachment.pgp>