[FFmpeg-cvslog] r15348 - in trunk/ffpresets: . libx264-default.ffpreset libx264-fastfirstpass.ffpreset libx264-hq.ffpreset libx264-max.ffpreset libx264-normal.ffpreset

[Robert Swain]

2008/9/17 Luca Abeni <lucabe72 at email.it>:
> Hi,
>
> superdump wrote:
>> Author: superdump
>> Date: Wed Sep 17 21:31:39 2008
>> New Revision: 15348
>>
>> Log:
>> libx264 ffpresets:
>>  * default - x264 CLI default values
>>  * fastfirstpass - disables options unnecessary for first pass
>>  * normal - Dark Shikari's Q55 preset
>>  * hq - Dark Shikari's Q75 preset
>>  * max - all options maxed out (at time of writing)
> [...]
>> Added: trunk/ffpresets/libx264-default.ffpreset
>> ==============================================================================
>> --- (empty file)
>> +++ trunk/ffpresets/libx264-default.ffpreset  Wed Sep 17 21:31:39 2008
>> @@ -0,0 +1,18 @@
>> +coder=1
> [...]
>
> Is it possible to include comments in a preset file?

It would seem not but a patch is apparently welcome. :)

> If yes, it would be useful to insert in the files the short descriptions you
> wrote in the changelog.
> If not, maybe we can have a README containing such descriptions?
> In this way, a user can know what every preset does without having to
> look at the changelog.

This information is desirable, but I'm not sure where it should go. If
it is as comments in each preset file then one has to look at a preset
file to know its goals. If it's in a centralised place, then as people
make their own presets and other groups make presets and don't
necessarily submit them to us, the information might not ever be
present.

I'm for having descriptive, useful comments in preset files but also
documenting presets somewhere in our docs.

Rob