[FFmpeg-cvslog] r18306 - trunk/libavformat/flvdec.c

Baptiste Coudurier baptiste.coudurier
Fri Apr 3 03:07:39 CEST 2009


Michael Niedermayer wrote:
> On Thu, Apr 02, 2009 at 02:40:59PM -0700, Baptiste Coudurier wrote:
>> Michael Niedermayer wrote:
>>> On Thu, Apr 02, 2009 at 10:30:49AM -0700, Baptiste Coudurier wrote:
>>>> On 4/2/2009 5:04 AM, Michael Niedermayer wrote:
>>>>> On Thu, Apr 02, 2009 at 05:52:20AM +0200, bcoudurier wrote:
>>>>>> Author: bcoudurier
>>>>>> Date: Thu Apr  2 05:52:19 2009
>>>>>> New Revision: 18306
>>>>>>
>>>>>> Log:
>>>>>> skip empty data packets in flv, fix input.flv
>>>>> Could you elaborate on what the problem was?
>>>> Sure: packet is empty, it only contains header, and no payload,
>>>> H.264 sequence end packet to be specific (type 2).
>>>> Flash player reads it correctly.
>>> I think this change will make a fix to issue271 tricky
>>> the decoder has to know how much silence to insert and this should
>>> match the duration of the single empty packet (i think)
>> Can't this silence be determined by comparing pts difference ?
> 
> i suspect it can but if the silence is long (and AFAIK this can be) the
> audio out could be starved by the time the next packet comes in.
> (I assume here the null packet is muxed earlier but did not verify this)
> 

Btw, did you notice the <=0 behind av_get_packet ?
So this actually changed failing on empty packets ;)

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org



More information about the ffmpeg-cvslog mailing list