[FFmpeg-cvslog] r18319 - trunk/libavcodec/x86/dsputil_mmx.c

[Reimar Döffinger]

On Thu, Apr 02, 2009 at 11:02:42PM +0200, alexc wrote:
> @@ -273,22 +272,41 @@ void put_pixels_clamped_mmx(const DCTELE
>              :"memory");
>  }
>  
> -static DECLARE_ALIGNED_8(const unsigned char, vector128[8]) =
> +DECLARE_ALIGNED_8(const unsigned char, ff_vector128[8]) =
>    { 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80 };

Hm, this is not used outside this file? I think then you should use
DECLARE_ASM_CONST...

> +    x86_reg av_uninit(line_skip3);
>  
> +            :"+r" (pixels), "+r" (line_skip3)

Uh, why? line_skip3 is not input, so why is it not =&r ?
And as noted in the other thread, pixels probably needs to be +&r