[FFmpeg-cvslog] r18306 - trunk/libavformat/flvdec.c

[Michael Niedermayer]

On Fri, Apr 03, 2009 at 06:45:51PM -0700, Baptiste Coudurier wrote:
> Hi Michael,
> 
> Michael Niedermayer wrote:
> > On Thu, Apr 02, 2009 at 06:07:39PM -0700, Baptiste Coudurier wrote:
> >> Michael Niedermayer wrote:
> >>> On Thu, Apr 02, 2009 at 02:40:59PM -0700, Baptiste Coudurier wrote:
> >>>> Michael Niedermayer wrote:
> >>>>> On Thu, Apr 02, 2009 at 10:30:49AM -0700, Baptiste Coudurier wrote:
> >>>>>> On 4/2/2009 5:04 AM, Michael Niedermayer wrote:
> >>>>>>> On Thu, Apr 02, 2009 at 05:52:20AM +0200, bcoudurier wrote:
> >>>>>>>> Author: bcoudurier
> >>>>>>>> Date: Thu Apr  2 05:52:19 2009
> >>>>>>>> New Revision: 18306
> >>>>>>>>
> >>>>>>>> Log:
> >>>>>>>> skip empty data packets in flv, fix input.flv
> >>>>>>> Could you elaborate on what the problem was?
> >>>>>> Sure: packet is empty, it only contains header, and no payload,
> >>>>>> H.264 sequence end packet to be specific (type 2).
> >>>>>> Flash player reads it correctly.
> >>>>> I think this change will make a fix to issue271 tricky
> >>>>> the decoder has to know how much silence to insert and this should
> >>>>> match the duration of the single empty packet (i think)
> >>>> Can't this silence be determined by comparing pts difference ?
> >>> i suspect it can but if the silence is long (and AFAIK this can be) the
> >>> audio out could be starved by the time the next packet comes in.
> >>> (I assume here the null packet is muxed earlier but did not verify this)
> >>>
> >> Btw, did you notice the <=0 behind av_get_packet ?
> >> So this actually changed failing on empty packets ;)
> > 
> > fixed that one, is the zero packet skip still needed?
> 
> Yes, codec is h.264.
> 
> But I guess it could be changed to this if you feel more comfortable.

iam curious why is it needed?
that is what happens without this?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090404/6064f7fd/attachment.pgp>