[FFmpeg-cvslog] r18460 - trunk/libavformat/flvdec.c

Michael Niedermayer michaelni
Sun Apr 12 06:16:11 CEST 2009


On Sat, Apr 11, 2009 at 09:06:19PM -0700, Baptiste Coudurier wrote:
> On Sun, Apr 12, 2009 at 06:01:03AM +0200, michael wrote:
> > Author: michael
> > Date: Sun Apr 12 06:01:03 2009
> > New Revision: 18460
> > 
> > Log:
> > Disable metadata reading, yes id like to know what this code is good for
> > and this is the easiest way to. It would be alot of messy code we can drop
> > if it is useless.
> > As a sideeffect this fixes issue977.
> > 
> > Modified:
> >    trunk/libavformat/flvdec.c
> > 
> > Modified: trunk/libavformat/flvdec.c
> > ==============================================================================
> > --- trunk/libavformat/flvdec.c	Sun Apr 12 05:26:20 2009	(r18459)
> > +++ trunk/libavformat/flvdec.c	Sun Apr 12 06:01:03 2009	(r18460)
> > @@ -342,7 +342,7 @@ static int flv_read_packet(AVFormatConte
> >          if ((flags & 0xf0) == 0x50) /* video info / command frame */
> >              goto skip;
> >      } else {
> > -        if (type == FLV_TAG_TYPE_META && size > 13+1+4)
> > +        if (type == FLV_TAG_TYPE_META && size > 13+1+4 && 0)
> >              flv_read_metabody(s, next);
> >          else /* skip packet */
> >              av_log(s, AV_LOG_ERROR, "skipping flv packet: type %d, size %d, flags %d\n", type, size, flags);
> 
> Humm, but you don't plan to export this in AVMetadata ?

audiosamplerate, audiocodecid, ... ?
no, thats no metadata in the AVMetadata sense

if there would be somehing like title and author yes that should be put in
AVMetadata but such things dont seem to be stored in there, at least not in
the files i looked at.

The only point i see of reading this "metadata" is for non standard sample
rates and codec ids, if mike says that doesnt exist and is not intended that
way then i dont see why this stuff should be read. Again if title and such
is set thats a different matter of course ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090412/c982b1c2/attachment.pgp>



More information about the ffmpeg-cvslog mailing list