[FFmpeg-cvslog] r18700 - trunk/libavcodec/avcodec.h

Michael Niedermayer michaelni
Mon Apr 27 20:22:09 CEST 2009


On Mon, Apr 27, 2009 at 08:00:46PM +0200, Vitor Sessak wrote:
> michael wrote:
>> Author: michael
>> Date: Mon Apr 27 14:28:56 2009
>> New Revision: 18700
>> Log:
>> Remove documentation from deprecated fields, they should not be used,
>> thus there is no sense in documenting them.
>
> [...]
>
>> Modified: trunk/libavcodec/avcodec.h
>> ==============================================================================
>> --- trunk/libavcodec/avcodec.h	Mon Apr 27 14:25:36 2009	(r18699)
>> +++ trunk/libavcodec/avcodec.h	Mon Apr 27 14:28:56 2009	(r18700)
>> @@ -1121,9 +1121,6 @@ typedef struct AVCodecContext {
>>      int b_frame_strategy;
>>       /**
>> -     * hurry up amount
>> -     * - encoding: unused
>> -     * - decoding: Set by user. 1-> Skip B-frames, 2-> Skip IDCT/dequant 
>> too, 5-> Skip everything except header
>>       * @deprecated Deprecated in favor of skip_idct and skip_frame.
>>       */
>>      int hurry_up;
>
> I don't think it really improves the situation. Imagine someone that 
> maintains the following third-party piece of code:
>
> ctx->hurry_up = 1;
>
> How is he supposed to know that he can replaces it by ctx->skip_idct=1 if 
> he has no documentation of what it was supposed to do? People have a 
> tendency of not touching code they do/can not understand...

feel free to revert

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090427/00815e5d/attachment.pgp>



More information about the ffmpeg-cvslog mailing list