[FFmpeg-cvslog] r29509 - trunk/libswscale/swscale.c

[Måns Rullgård]

Ramiro Polla <ramiro.polla at gmail.com> writes:

> On Thu, Aug 13, 2009 at 4:24 PM, Reimar
> D?ffinger<Reimar.Doeffinger at gmx.de> wrote:
>> On Thu, Aug 13, 2009 at 08:29:54PM +0200, ramiro wrote:
>>> +#ifdef MAP_ANONYMOUS
>>> + ? ? ? ? ? ?mprotect(c->lumMmx2FilterCode, MAX_MMX2_FILTER_CODE_SIZE, PROT_EXEC | PROT_READ);
>>> + ? ? ? ? ? ?mprotect(c->chrMmx2FilterCode, MAX_MMX2_FILTER_CODE_SIZE, PROT_EXEC | PROT_READ);
>>
>> Both for mmap and mprotect: Why PROT_READ though? I don't think
>> EXEC without read is possible on most architectures, but still we
>> do not need read access in any case I think...
>
> Mans, or anyone else that knows an extensive amount of platforms, can
> you comment on this?

On ARM read permission is required to execute.  I see no harm in
always requesting both.

>> Also I don't think that's ok, MAP_ANONYMOUS does not imply that mprotect is
>> available, this would have to be an extra configure check or something.
>
> FATE hasn't budged. Can we wait for such a system before adding
> another check?

Fine by me.

-- 
M?ns Rullg?rd
mans at mansr.com