[FFmpeg-cvslog] r19649 - in trunk/libavcodec: acelp_filters.c acelp_filters.h

[Michael Niedermayer]

On Sat, Aug 15, 2009 at 01:44:58PM +0200, Reimar D?ffinger wrote:
> On Sat, Aug 15, 2009 at 01:22:55PM +0200, superdump wrote:
> > Author: superdump
> > Date: Sat Aug 15 13:22:55 2009
> > New Revision: 19649
> > 
> > Log:
> > Add a function that can apply an order 2 rational transfer function in-place.
> > This function will be used in the upcoming AMR-NB floating point decoder for
> > high-pass filtering.
> > 
> > Patch by Colin McQuillan ( m.niloc googlemail com )
> > 
> > Modified:
> >    trunk/libavcodec/acelp_filters.c
> >    trunk/libavcodec/acelp_filters.h
> > 
> > Modified: trunk/libavcodec/acelp_filters.c
> > ==============================================================================
> > --- trunk/libavcodec/acelp_filters.c	Sat Aug 15 13:12:47 2009	(r19648)
> > +++ trunk/libavcodec/acelp_filters.c	Sat Aug 15 13:22:55 2009	(r19649)
> > @@ -93,3 +93,20 @@ void ff_acelp_high_pass_filter(int16_t* 
> >          hpf_f[0] = tmp;
> >      }
> >  }
> > +
> > +void ff_acelp_apply_order_2_transfer_function(float *buf,
> > +                                              const float zero_coeffs[2],
> > +                                              const float pole_coeffs[2],
> > +                                              float gain, float mem[2], int n)
> > +{
> > +    int i;
> > +    float tmp;
> > +
> > +    for (i = 0; i < n; i++) {
> > +        tmp = gain * buf[i] - pole_coeffs[0] * mem[0] - pole_coeffs[1] * mem[1];
> 
> Why not merge declaration and initialization? That also makes it clear
> that the value is not reused over loop iterations.

i already suggested that but was ignored by the author, thought its not
worth the fight ... :)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090816/4c95c885/attachment.pgp>