[FFmpeg-cvslog] r19744 - trunk/libavcodec/rv34.c

Reimar Döffinger Reimar.Doeffinger
Sun Aug 30 09:47:10 CEST 2009


On Sun, Aug 30, 2009 at 08:30:53AM +0200, kostya wrote:
> @@ -37,6 +37,10 @@
>  
>  //#define DEBUG
>  
> +#define ZERO8x2(dst, stride) \
> +    fill_rectangle(dst,                 1, 2, stride, 0, 4); \
> +    fill_rectangle(((uint8_t*)(dst))+4, 1, 2, stride, 0, 4); \
> +

Please, make this a static inline function

> -    if(block_type == RV34_MB_B_BACKWARD || block_type == RV34_MB_B_FORWARD)
> -        fill_rectangle(cur_pic->motion_val[!dir][mv_pos], 2, 2, s->b8_stride, 0, 4);
> +    if(block_type == RV34_MB_B_BACKWARD || block_type == RV34_MB_B_FORWARD){
> +        ZERO8x2(cur_pic->motion_val[!dir][mv_pos], s->b8_stride);
> +    }

Instead of doing such confusing hacks that sooner or later someone will
break due to misunderstanding (no, such a break probably will not hit
SVN but still it is unkind to set up such traps in code).



More information about the ffmpeg-cvslog mailing list