[FFmpeg-cvslog] r20747 - trunk/libavcodec/vp3.c

[Dominik 'Rathann' Mierzejewski]

On Sunday, 06 December 2009 at 13:48, darkshikari wrote:
> Author: darkshikari
> Date: Sun Dec  6 13:48:09 2009
> New Revision: 20747
> 
> Log:
> Various VP3 optimizations.
> Faster checks in reverse_dc_prediction.
> Simplified deblocking checks.
> Check transform==15 first, since it's more common than 13.

And again, you commit cosmetic changes (indentation, this time) mixed
with functional.

> -                /* do not perform left edge filter for left columns frags */
> -                if ((x > 0) &&
> -                    (s->all_fragments[fragment].coding_method != MODE_COPY)) {
> -                    s->dsp.vp3_h_loop_filter(
> -                        plane_data + s->all_fragments[fragment].first_pixel,
> -                        stride, bounding_values);
> -                }
> +                /* This code basically just deblocks on the edges of coded blocks.
> +                 * However, it has to be much more complicated because of the
> +                 * braindamaged deblock ordering used in VP3/Theora. Order matters
> +                 * because some pixels get filtered twice. */
> +                if( s->all_fragments[fragment].coding_method != MODE_COPY )
> +                {
> +                    /* do not perform left edge filter for left columns frags */
> +                    if (x > 0) {
> +                        s->dsp.vp3_h_loop_filter(
> +                            plane_data + s->all_fragments[fragment].first_pixel,
> +                            stride, bounding_values);
> +                    }

Here.

>  
> -                /* do not perform top edge filter for top row fragments */
> -                if ((y > 0) &&
> -                    (s->all_fragments[fragment].coding_method != MODE_COPY)) {
> -                    s->dsp.vp3_v_loop_filter(
> -                        plane_data + s->all_fragments[fragment].first_pixel,
> -                        stride, bounding_values);
> -                }
> +                    /* do not perform top edge filter for top row fragments */
> +                    if (y > 0) {
> +                        s->dsp.vp3_v_loop_filter(
> +                            plane_data + s->all_fragments[fragment].first_pixel,
> +                            stride, bounding_values);
> +                    }

Here.
And so on...

I think this should be reverted and recommitted in two parts, per FFmpeg's
SVN rules.

Regards,
R.

-- 
MPlayer http://mplayerhq.hu | RPMFusion http://rpmfusion.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan