[FFmpeg-cvslog] r20829 - in trunk/libavutil: avstring.c avstring.h avutil.h

Michael Niedermayer michaelni
Mon Dec 14 02:17:55 CET 2009


On Mon, Dec 14, 2009 at 02:11:07AM +0100, Michael Niedermayer wrote:
> On Sun, Dec 13, 2009 at 11:22:31PM +0100, Diego Biurrun wrote:
> > On Sun, Dec 13, 2009 at 06:09:41PM +0100, michael wrote:
> > > 
> > > --- trunk/libavutil/avstring.c	Sun Dec 13 17:20:00 2009	(r20828)
> > > +++ trunk/libavutil/avstring.c	Sun Dec 13 18:09:41 2009	(r20829)
> > > @@ -76,3 +76,9 @@ size_t av_strlcatf(char *dst, size_t siz
> > > +
> > > +char *av_d2str(double d){
> > > +    char *str= av_malloc(16);
> > > +    if(str) snprintf(str, 16, "%f", d);
> > > +    return str;
> > > +}
> > 
> > This file had nice, consistent K&R style before you messed it up with
> > this commit.
> > 
> 
> > I must say that I cannot shake the impression that you do not apply
> > many of the rules of this project to yourself.
> 
> I try to follow the rules i expect others to follow, i dont remember
> asking others for strict K&R formatting, thats what you do and i complained
> about it several times when you complained about others not following K&R
> strictly to the last space.
> 
> Ill try to fix this of course but i still think its a waste of the manpower
> we do have.

Besides, this of course was a oversight, iam not intentionally placing the
functions { in a K&R incompatible place.
Its just that i concentrate on write correct/simple/fast/... code and not
on K&R formatting rules

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20091214/1032324b/attachment.pgp>



More information about the ffmpeg-cvslog mailing list