[FFmpeg-cvslog] r20725 - in trunk/libavcodec: h263.c mpegvideo.h mpegvideo_enc.c

[Michael Niedermayer]

On Thu, Dec 24, 2009 at 05:31:37PM +0100, Diego Biurrun wrote:
> On Thu, Dec 24, 2009 at 01:49:08PM +0100, Adrian Stutz wrote:
> > >
> > > Log:
> > > Move ff_init_qscale_tab() from h263.c to mpegvideo, the function is not h263 specific.
> > >
> > > Modified:
> > >    trunk/libavcodec/h263.c
> > >    trunk/libavcodec/mpegvideo.h
> > >    trunk/libavcodec/mpegvideo_enc.c
> > 
> > This broke compiling for me on OSX with the following error:
> > > Undefined symbols:
> > >   "_ff_init_qscale_tab", referenced from:
> > >       _ff_clean_h263_qscales in h263.o
> > > ld: symbol(s) not found
> > > collect2: ld returned 1 exit status
> > > make: *** [libavcodec.52.dylib] Error 1
> > 
> > These are my configure options:
> > ./configure --enable-gpl --enable-shared --disable-static
> > --disable-ffmpeg --disable-ffserver --enable-pthreads
> > --disable-devices --disable-encoders --disable-muxers
> > --disable-network --enable-postproc --enable-encoder=png
> > 
> > Reverting the commit made the error go away.
> 
> The problem is that h263.c now depends on mpegvideo_enc.c.  This is not good.
> The code should be moved somewhere else that is not encoder-specific.

The code is encoder specific, so it belongs in a file that is encoder
specific


> 
> Michael, why did you move ff_init_qscale_tab at all, it is only used in
> h263.c ...

see the next commit

and i suggest we revert the whole mpegvideo split
As it is currently, functions are placed randomly and iam already failing to
find them quite often and end up with grep mpegvideo*
h263 specific code belongs in h263*, encoder specific code belongs in *enc if
such files exist.
h263.c does and MUST depend on mpegvideo_enc unless h263enc.c exists
that is h263.c contains decoder & encoder specific code currently

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20091224/26e008aa/attachment.pgp>