[FFmpeg-cvslog] r17068 - in trunk/libavformat: audiointerleave.c audiointerleave.h

Baptiste Coudurier baptiste.coudurier
Mon Feb 9 00:09:34 CET 2009


Diego Biurrun wrote:
> On Sun, Feb 08, 2009 at 10:09:50PM +0100, bcoudurier wrote:
>> Log:
>> add static, function unused outside
> 
> How about something like
> 
>   Declare ff_interleave_new_audio_packet as static, it is not used
>   outside of audiointerleave.c.  Also remove the function declaration
>   from the header as it is now static.
> 
> May I politely request that you make a bit more of an effort to write
> descriptive commit messages?  They are an important part of the
> project documentation.

Commit messages are _not_ part of project documentation.

Besides, Im sorry but I still think the commit message cannot be
separated from the diff, and I won't change my mind.

Now if you want to change the commit message, feel free to do so, but I
consider commit messages, on which you commented, fine.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org




More information about the ffmpeg-cvslog mailing list