[FFmpeg-cvslog] r17310 - in trunk/libavcodec: mpegvideo_xvmc.c xvmc.h

[Reimar Döffinger]

On Sun, Feb 15, 2009 at 03:59:25PM +0100, Michael Niedermayer wrote:
> wOn Sun, Feb 15, 2009 at 03:36:43AM +0100, iive wrote:
> > Author: iive
> > Date: Sun Feb 15 03:36:43 2009
> > New Revision: 17310
> > 
> > Log:
> > Give a little better name to the magic(_id) field in xvmc struct
> 
> from wikipedia
> "Magic, sometimes known as sorcery, is a conceptual system that asserts human ability to control or predict the natural world (including events, objects, people, and physical phenomena) through mystical, paranormal or supernatural means. The term can also refer to the practices employed by a person asserting this ability, and to beliefs that explain various events and phenomena in such terms. In many cultures the concept of magic is under pressure from, and in competition with, scientific and religious conceptual systems. This is particularly the case in the Christian West and the Muslim Middle East where the practice of magic is generally regarded as blasphemous or forbidden by orthodox leadership.
> "
> 
> which part of this applies here and how? 

I'd say: it protects against the buffers being altered are swapped
against non-xvmc ones via supernatural means.
If you haven't guessed I think the XvMC code is in many places overdoing
the checking (and this specifically IMO is one), none of the other code
tries to check and recheck that the buffer returned by get_buffer is
valid.