[FFmpeg-cvslog] r17549 - trunk/libavcodec/pixdesc.h

Michael Niedermayer michaelni
Tue Feb 24 02:38:41 CET 2009


On Mon, Feb 23, 2009 at 05:21:24PM -0800, Baptiste Coudurier wrote:
> Hi Michael,
> 
> On 2/23/2009 5:12 PM, michael wrote:
> > Author: michael
> > Date: Tue Feb 24 02:12:25 2009
> > New Revision: 17549
> > 
> > Log:
> > AVPixFmtDescriptor doxy
> > 
> > Modified:
> >    trunk/libavcodec/pixdesc.h
> > 
> > Modified: trunk/libavcodec/pixdesc.h
> > ==============================================================================
> > --- trunk/libavcodec/pixdesc.h	Tue Feb 24 02:08:29 2009	(r17548)
> > +++ trunk/libavcodec/pixdesc.h	Tue Feb 24 02:12:25 2009	(r17549)
> > @@ -31,6 +31,14 @@ typedef struct AVComponentDescriptor{
> >      uint16_t depth_minus1 :4;            ///< number of bits in the component minus 1
> >  }AVComponentDescriptor;
> >  
> > +/**
> > + * Descriptor that unambigously describes how the bits of a pixel are
> > + * stored in the up to 4 data planes of an image. It also stores the
> > + * subsampling factors and number of components.
> > + *
> > + * @note This is seperate of the colorspace (RGB, YCbCr, YPbPr, jpeg style YUV and all the YUV variants)
> > + *       AVPixFmtDescripto just stores how values are stored not what these values represent.
> > + */
> 
> This is very cool, thanks a lot.
> 
> Quick question, should we adapt:
> 
> #define SWS_CS_ITU709         1
> #define SWS_CS_FCC            4
> #define SWS_CS_ITU601         5
> #define SWS_CS_ITU624         5
> #define SWS_CS_SMPTE170M      5
> #define SWS_CS_SMPTE240M      7
> #define SWS_CS_DEFAULT        5
> 
> And define it along in pixdesc.h ?

iam in favor of adding an enum with the above values
maybe AVColorspace?
to some header
and add a colorspace field to AVCodecContext

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090224/d4ac07ad/attachment.pgp>



More information about the ffmpeg-cvslog mailing list