[FFmpeg-cvslog] r16425 - in trunk: libavcodec/Makefile libavcodec/avcodec.h libavcodec/metadata.c libavcodec/metadata.h libavformat/Makefile libavformat/avformat.h libavformat/metadata.c libavformat/metadata.h

[Aurelien Jacobs]

Michael Niedermayer wrote:

> On Sun, Jan 04, 2009 at 09:37:57PM +0100, Diego Biurrun wrote:
> > On Sun, Jan 04, 2009 at 07:58:49PM +0100, michael wrote:
> > > 
> > > Log:
> > > Move metadata API from avcodec to avformat.
> > 
> > Sorry to be blunt, but what nonsense is this?
> > 
> > In one commit you add this to libavcodec, in the next you move
> > it to libavformat.  What was this good for apart from commit
> > spam?
> 
> let me explain
> 
> [...]
> 6. i move it to avformat

Thanks for doing it.

> i now see that aurel wanted me to not commit avi* yet,

indeed.

> well i overread that one though i think commiting it was better anyway.
> we should move forward not waste time with inventing complex bandaids,
> to patch up some temporary loss of functionality.
> Or in other words IMHO energy should be used to update (de)muxers to the
> new API instead of finding some hacks that allow old and new to pass
> metadata between each other.

Well, the problem is not exactly passing metadata between old and new
demuxers. I agree that we don't need to care about this. Updating
demuxers is easy enough.
The problem is actually with all the software which still use the old
API. Right now, when they try muxing metadata in avi, there will be no
error, but no metadata will be written. This more or less "breaks" the
API.
But that's not a big problem. I will have some patches ready soon
to fix backward compatibility for old apps.

Aurel