[FFmpeg-cvslog] r19091 - trunk/libavcodec/4xm.c

[Baptiste Coudurier]

On 6/5/2009 1:10 PM, Michael Niedermayer wrote:
> On Fri, Jun 05, 2009 at 10:12:14AM +0200, bcoudurier wrote:
>> Author: bcoudurier
>> Date: Fri Jun  5 10:12:14 2009
>> New Revision: 19091
>>
>> Log:
>> 4xm decoder uses get_buffer, set CODEC_CAP_DR1
> 
> i think you broke several decoders with these changes, no i dont
> know which but
> CODEC_CAP_DR1 does not just mean the codec uses get_buffer()
> but it means it works with any get_buffer() implementation while
> lack of CODEC_CAP_DR1 means it requires the libavcodec internal get_buffer()

Interesting, I did misunderstand the Doxygen then:
/**
 * Codec uses get_buffer() for allocating buffers.
 * direct rendering method 1
 */
#define CODEC_CAP_DR1             0x0002

> one case (that applies to 4xm IIRC) is that linesize == width*bpp is required
> by some decoders

Well, user can override the function in any case, so decoder must not
use get_buffer in AVCodecContext IMHO.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org