[FFmpeg-cvslog] r29354 - trunk/libswscale/swscale-example.c

[Michael Niedermayer]

On Thu, Jun 11, 2009 at 06:08:35PM +0200, Diego Biurrun wrote:
> On Thu, Jun 11, 2009 at 05:46:11PM +0200, Michael Niedermayer wrote:
> > On Thu, Jun 11, 2009 at 05:15:43PM +0200, diego wrote:
> > > 
> > > Log:
> > > Fix compilation: #undef standard library functions that are
> > > forbidden within FFmpeg, but allowed in example code.
> > 
> > example code should not define HAVE_AV_CONFIG_H and if it does not,
> > it also does ot need the undefs
> 
> Well...:
> 
> diego at slaughter:/var/tmp/ffmpeg$ make examples
> gcc -DHAVE_AV_CONFIG_H -I. -I"/var/tmp/ffmpeg" -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200112 -std=c99 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -fomit-frame-pointer -g -Wdeclaration-after-statement -Wall -Wno-switch -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wno-pointer-sign -Wcast-qual -Wwrite-strings -Wundef -O3 -fno-math-errno        -c -o libswscale/swscale-example.o libswscale/swscale-example.c
> libswscale/swscale-example.c: In function `doTest':
> libswscale/swscale-example.c:81: warning: implicit declaration of function `please_use_av_malloc'
> libswscale/swscale-example.c:85: warning: implicit declaration of function `please_use_av_log_instead_of_perror'
> libswscale/swscale-example.c:94: warning: implicit declaration of function `please_use_av_log_instead_of_fprintf'
> libswscale/swscale-example.c:139: warning: implicit declaration of function `please_use_av_log_instead_of_printf'
> libswscale/swscale-example.c:152: warning: implicit declaration of function `please_use_av_free'
> 
> The compile command line does indeed contain -DHAVE_AV_CONFIG_H, which
> arguably is false, but:
> 
> diego at slaughter:/var/tmp/ffmpeg$ gcc -I.  -I"/var/tmp/ffmpeg" -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200112 -std=c99 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -fomit-frame-pointer -g -Wdeclaration-after-statement -Wall -Wno-switch -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wno-pointer-sign -Wcast-qual -Wwrite-strings -Wundef -O3 -fno-math-errno        -c -o libswscale/swscale-example.o libswscale/swscale-example.c
> libswscale/swscale-example.c: In function `doTest':
> libswscale/swscale-example.c:81: warning: implicit declaration of function `please_use_av_malloc'
> libswscale/swscale-example.c:85: warning: implicit declaration of function `please_use_av_log_instead_of_perror'
> libswscale/swscale-example.c:94: warning: implicit declaration of function `please_use_av_log_instead_of_fprintf'
> libswscale/swscale-example.c:139: warning: implicit declaration of function `please_use_av_log_instead_of_printf'
> libswscale/swscale-example.c:152: warning: implicit declaration of function `please_use_av_free'
> 
> There is no improvement if I remove the definition from the command
> line...
> 
> > this commit is not the correct solution
> 
> Whoever knows the correct solution shall step forward...

I do, revert your previous commit to swscale (r29353) as well and it works

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090611/939e502a/attachment.pgp>