[FFmpeg-cvslog] r29353 - trunk/libswscale/swscale_internal.h

[Diego Biurrun]

On Thu, Jun 11, 2009 at 10:29:44AM -0700, Baptiste Coudurier wrote:
> 
> On 6/11/2009 10:24 AM, Diego Biurrun wrote:
> > On Thu, Jun 11, 2009 at 06:44:47PM +0200, Michael Niedermayer wrote:
> >> On Thu, Jun 11, 2009 at 12:19:04PM +0200, diego wrote:
> >>> Log:
> >>> Add libavutil/internal.h #include, required for the DECLARE_ALIGNED macro.
> >>> This fixes swscale-example compilation.
> >>>
> >>> --- trunk/libswscale/swscale_internal.h	Sun Jun  7 16:42:43 2009	(r29352)
> >>> +++ trunk/libswscale/swscale_internal.h	Thu Jun 11 12:19:04 2009	(r29353)
> >>> @@ -28,6 +28,7 @@
> >>>  #endif
> >>>  
> >>>  #include "libavutil/avutil.h"
> >>> +#include "libavutil/internal.h"
> >> anyone against me renaming this header to
> >> internal_to_libavutil_under_absolutely_no_circumstances_include_this_outside_libavutil.h
> >> ?
> > 
> > Not #include it outside of a header that does not exist?
> > 
> > Anyway, swscale_internal.h uses the DECLARE_ALIGNED macro, so there is
> > no way around including libavutil/internal.h here.
> 
> We could rename it consistently to internal.h though :)

I'm all for it.  Anyone against?

Diego