[FFmpeg-cvslog] r29354 - trunk/libswscale/swscale-example.c

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Fri, Jun 12, 2009 at 09:39:11AM +0100, M?ns Rullg?rd wrote:
>> M?ns Rullg?rd <mans at mansr.com> writes:
>> 
>> > Diego Biurrun <diego at biurrun.de> writes:
>> >
>> >> On Fri, Jun 12, 2009 at 02:06:41AM +0100, M?ns Rullg?rd wrote:
>> >>> 
>> >>> For the record, the stuff in libavutil/internal.h is intended to be
>> >>> used everywhere in FFmpeg.  All that used to be scattered about
>> >>> common.h under separate #ifdef HAVE_AV_CONFIG_H.  We moved it to a
>> >>> separate file to clean things up a bit.
>> >>
>> >> Didn't I just hear Michael say the opposite?
>> >
>> > He's wrong then.  Just look at the file.  Some of it is *only* used in
>> > lavc even.  The name "internal" means internal to FFmpeg, not to lavu.
>> 
>> Forgot to say, #including libavutil/internal.h directly is wrong,
>> common.h should be used.
>
> Why?

The fact that it's split from common.h is an implementation detail.
Please look at the history of those files.

-- 
M?ns Rullg?rd
mans at mansr.com