[FFmpeg-cvslog] r17761 - trunk/libavformat/http.c

Reimar Döffinger Reimar.Doeffinger
Tue Mar 3 17:51:57 CET 2009


On Tue, Mar 03, 2009 at 11:28:43AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Tue, Mar 3, 2009 at 9:23 AM, Reimar D?ffinger
> <Reimar.Doeffinger at gmx.de> wrote:
> > On Tue, Mar 03, 2009 at 02:26:17PM +0100, rbultje wrote:
> >> Author: rbultje
> >> Date: Tue Mar ?3 14:26:17 2009
> >> New Revision: 17761
> >>
> >> Log:
> >> Fix allocated length of the HTTP authentication request field buffer, as
> >> noticed by Stefano and Luca in the "[PATCH]RTSP Basic Authentication"
> >> mailinglist thread.
> [..]
> > IMHO "fix" is a bad choice of words, it was not really wrong,
> > just a bit bigger than necessary?
> 
> s/fix/reduce/ ok?

Yes, that works to avoid misunderstandings.
I'd probably write something like "reduce size of buffer for
base64-encoded string, the <name of base64 function> implementation was
changed to need less/no extra space" (since it caused no bug, e.g. that
it is related to the "HTTP authentication request field buffer" seems
completely uninteresting to me).
But write whatever you like, my intention is not to force my idea of
commit messages on anyone, just trying to help improve everyone's "commit
message writing skill" :-)




More information about the ffmpeg-cvslog mailing list