[FFmpeg-cvslog] r17910 - trunk/libavformat/rmdec.c

Kostya kostya.shishkov
Mon Mar 9 18:33:19 CET 2009


On Mon, Mar 09, 2009 at 02:08:20PM +0100, rbultje wrote:
> Author: rbultje
> Date: Mon Mar  9 14:08:19 2009
> New Revision: 17910
> 
> Log:
> Prevent (negative) overflow of rm->remaining_len. This evaluation really only
> has two possible outcomes: either len and rm->remaining_len are the same, in
> which case we care about the outcome and it is zero, or rm->remaining_len is
> currently not in use and we don't care about the outcome. In that case, len
> is positive and rm->remaining_len is zero, which leads to a negative result.
> This is confusing and could eventually lead to a sign-flip if we skip a lot
> of packets (unlikely, but still). Therefore, just always set it to zero.
> 
> Modified:
>    trunk/libavformat/rmdec.c

Looks ok.




More information about the ffmpeg-cvslog mailing list