[FFmpeg-cvslog] r17905 - trunk/libavformat/utils.c

Baptiste Coudurier baptiste.coudurier
Fri Mar 13 22:18:46 CET 2009


Hi Reimar,

On 3/13/2009 12:55 PM, Reimar D?ffinger wrote:
> On Fri, Mar 13, 2009 at 12:38:08PM -0700, Baptiste Coudurier wrote:
>> On 3/9/2009 11:50 AM, Baptiste Coudurier wrote:
>>> On 3/9/2009 8:36 AM, Reimar D?ffinger wrote:
>>>>> if (tag == TAG_VIDEOSTREAM && !vst) {
>>>> but this only seems to work as long as there is no data packet
>>>> in-between.
>>>> A cleanup job for the maintainer maybe? :-)
>>> I'll have a look.
>> Should be better now.
> 
> That part yes, but seeking is still broken for some reason.

It's broken because it's not supported. no read_timestamp no generic
seeking.

> There are two things at least that are still wrong I think, in line 113:
>> av_set_pts_info(vst, 64, 256, swf->frame_rate);
>> vst->codec->time_base = (AVRational){ 256, swf->frame_rate };
> 
> I think the second line should not be there.

Well, maybe, It could be removed if everything works correctly with the
frame rate guessing code I believe.

> And in the first line, the "64" should be "16", because pkt->pts is read
> from a 16-bit frame counter.

That is probably right.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org




More information about the ffmpeg-cvslog mailing list