[FFmpeg-cvslog] r18134 - trunk/libavformat/mov.c

[Baptiste Coudurier]

Hi Aurelien,

On 3/22/2009 7:38 AM, Aurelien Jacobs wrote:
> On Sun, Mar 22, 2009 at 12:29:34AM +0100, bcoudurier wrote:
>> Author: bcoudurier
>> Date: Sun Mar 22 00:29:34 2009
>> New Revision: 18134
>>
>> Log:
>> reset codec width/height for h264 forcing decoder to parse extradata
>>
>> Modified:
>>    trunk/libavformat/mov.c
>>
>> Modified: trunk/libavformat/mov.c
>> ==============================================================================
>> --- trunk/libavformat/mov.c	Sun Mar 22 00:08:20 2009	(r18133)
>> +++ trunk/libavformat/mov.c	Sun Mar 22 00:29:34 2009	(r18134)
>> @@ -1440,6 +1440,9 @@ static int mov_read_trak(MOVContext *c, 
>>  #if CONFIG_H263_DECODER
>>      case CODEC_ID_H263:
>>  #endif
>> +#if CONFIG_H264_DECODER
>> +    case CODEC_ID_H264:
>> +#endif
>>  #if CONFIG_MPEG4_DECODER
>>      case CODEC_ID_MPEG4:
>>  #endif
> 
> All the #if look strange here. Is there really any reason why the lavf
> mov demuxer should behave differently depending on whether a h264 decoder
> is compiled in lavc or not.
> 

Well if no decoder, parameters cannot be computed, so better no
unsetting them, you might compile without the decoder for whatever reason.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org