[FFmpeg-cvslog] r18896 - trunk/libavcodec/eatgq.c

Reimar Döffinger Reimar.Doeffinger
Sat May 23 16:46:31 CEST 2009

On Fri, May 22, 2009 at 10:27:35PM +0100, M?ns Rullg?rd wrote:
> reimar <subversion at mplayerhq.hu> writes:
> > Author: reimar
> > Date: Fri May 22 20:39:00 2009
> > New Revision: 18896
> >
> > Log:
> > Move eatgq blocks array from the stack to the codec context and make sure
> > it is aligned as necessary for DSPContext's idct_put.
> > Just aligning it on the stack would have been possible but less reliable
> > and without any real benefit.
> Aligning for idct on the stack is *not* possible.  It may work by
> accident most of the time, but DO NOT RELY ON IT.

Given we have added gcc attributes to realign the stack etc. I conclude
that someone somewhen wanted it to be possible, and I'm not sure you
have to rely on "accident" for it to work with gcc/Linux at least.
So it seems to me that the commit message is quite accurate, even if we
might want to avoid aligned data on the stack completely in the future.

More information about the ffmpeg-cvslog mailing list