[FFmpeg-cvslog] r18959 - in trunk: libavcodec/mpeg12.c tests/seek.regression.ref

[Michael Niedermayer]

On Tue, May 26, 2009 at 11:38:19PM -0700, Baptiste Coudurier wrote:
> On 5/26/2009 9:40 PM, Mike Melanson wrote:
> > bcoudurier wrote:
> >> Author: bcoudurier
> >> Date: Wed May 27 02:14:32 2009
> >> New Revision: 18959
> >>
> >> Log:
> >> Fix off by one offset with fetch_timestamps, pts_parser_problem.mpg.
> >> Patch by Wolfram Gloger, wmglo at dentm dot med dot uni-muenchen dot de.
> >>
> >> Modified:
> >>    trunk/libavcodec/mpeg12.c
> >>    trunk/tests/seek.regression.ref
> > 
> > Do you have any idea why this might have broken the pva-demux test?
> > 
> > http://fate.multimedia.cx/index.php?test_spec=298
> > 
> > The file errors out with the following message:
> > 
> > [NULL @ 0x120ab5730]error, non monotone timestamps 50151 >= 42951
> > av_interleaved_write_frame(): Error while opening file
> 
> Yes, that's because now frames have pts correctly set :)
> This PVA samples does not start with a SEQ EXT therefore first frames
> dts are not computed accurately.
> 

> Btw, any reason for not setting has_b_frames when a B frame is
> encountered or I frame with temp_ref != 0 ?

i guess setting has_b_frames when a b frame is hit is ok, though maybe
this could be done at a more central place

for checks on temp_ref i feel uneasy because the value is not used by
anything in any sane decoder and thus i have some doubts that it is reliable
it could (in theory) cause low delay mpegs to be decoded with 1 frame delay
messing AV sync up

also the whole reminds me that ffmpeg.c's timestamp handling needs to be
improved to better deal with invalid input

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090527/caac3098/attachment.pgp>