[FFmpeg-cvslog] r20502 - in trunk: configure libavcodec/allcodecs.c libavcodec/h263dec.c libavcodec/imgconvert.c libavcodec/vdpau.c libavcodec/vdpau.h libavcodec/vdpau_internal.h libavutil/pixfmt.h

[Uoti Urpala]

On Wed, 2009-11-11 at 21:10 +0000, Carl Eugen Hoyos wrote:
> M?ns Rullg?rd <mans <at> mansr.com> writes:
> > Jai Menon <jmenon86 <at> gmail.com> writes:
> > > My understanding (based on [1]) is that mpeg4 asp is supported in
> > > packages > 190.32. Shouldn't we use some kind of version checking to
> > > make sure we aren't building against older driver packages. Currently,
> > > building against older libvdpau leads to build errors (as is expected).
> 
> [...]
> 
> > Update the check in configure to test for something that's only in
> > recent enough versions.
> 
> While I am certainly not against such a test (MPlayer's configure tests for the
> definition of VDP_VIDEO_MIXER_FEATURE_HIGH_QUALITY_SCALING_L1), I'd like to note
> that
> 1) There was never a released version of libvdpau that does not support current
> svn (only of binary NVIDIA drivers before libvdpau was released as an
> open-source library that needs - currently proprietary - implementations).

When talking about a configure check it doesn't make all that much
difference which versions were released with the NVIDIA drivers and
which as a separate library. Even if you consider the latter as more
important to be supported in FFmpeg, configure should be able to detect
whether a suitable library is installed or not. Now older versions are
not just unsupported but trigger a complete build failure in FFmpeg. And
people are going to have them installed because they were included by
default with previous NVIDIA drivers.

> 2) I do not know of any use for --enable-vdpau so far.
> (It is - sadly! - only used by statically compiled MPlayer)

What are you you talking about? VDPAU is enabled by default if the
headers are detected, so explicit --enable-vdpau isn't needed to trigger
the problems. And you should know that "statically compiled MPlayer" is
not the only case where FFmpeg VDPAU code is used - or what are you
referring to?